Added restartOnConfigChange flag to trigger Gateway Deployment if configMap changes during helm upgrade #261
Conversation
…uring helm upgrade
…dd_restartOnConfigChange_annotation
DamandeepToor
changed the title
DamandeepToor
changed the title
There was a problem hiding this comment.
There are no changes to the gateway-otk chart - is there a reason the version has been incremented?
For the documentation update (readme) please follow the current format. This release should have a dedicated header with any changes highlighted. Please also specify which config value changes will initiate a restart (as this only applies to the default configmap).
The deployment template doesn't account for no annotations. Kubernetes might automatically patch this but it would be better to either reference an empty object {} or not include it which is what happens currently.
The checksum will be added twice if additional annotations are present, the first if should check if there are additionalAnnotations.
…nd handled no annotations along with not checking restartOnConfigChange flag with additionalAnnotations
Description of the change
Added restartOnConfigChange flag to trigger Gateway Deployment if configMap changes during helm upgrade
Benefits
Example , if User switches from one Database Server to Another , configMap will change and with change , user can control if gateway gets redeployed automatically or manually wants to restart the Gateway pods
Drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.[charts/gateway])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files